2947_We_need_to_fix_some_remaining_Issues_on_collab_channel

serge-web / serge

Serious Gaming, Evolved - web interface

https://sites.google.com/deepbluec.com/serge/

Apache License 2.0

14 stars 4 forks source link

2947_We_need_to_fix_some_remaining_Issues_on_collab_channel #2976

Open lilitkarapetyan opened 1 month ago

lilitkarapetyan commented 1 month ago

Fixes #2947 Fixes #2939

🧰 Issue

🚀 Overview:

🔗 Link to preview

🤔 Reason:

🔨Work carried out:

[x] Tests pass

🖥️ Screenshot

Confirmations

[ ] I have chosen reviewers for my PR.
[ ] I have assigned myself to this PR.
[ ] I have chosen an appropriate label for the PR.
[ ] I have completed the mandatory sections of this document.
[ ] I have deleted any unused sections.
[ ] I confirm that I have checked for required README updates and acted accordingly.

📝 Developer Notes:

lilitkarapetyan commented 1 month ago

fixes #2947

IanMayo commented 1 month ago

Is this ready to go @Tristina1788 ? Does it fix the problems in the linked issues?

Tristina1788 commented 1 month ago

Is this ready to go @Tristina1788 ? Does it fix the problems in the linked issues?

@IanMayo We still have these issues on this https://github.com/serge-web/serge/issues/2947#issuecomment-2173454617 . Could you help to confirm we should fix these issues on this PR or not?

IanMayo commented 2 weeks ago

Is this ready to go @Tristina1788 ? Does it fix the problems in the linked issues?

@IanMayo We still have these issues on this #2947 (comment) . Could you help to confirm we should fix these issues on this PR or not?

Yes @Tristina1788 - those are valid issues, that I would like fixed in this PR, please @lilitkarapetyan

Except:

And in 'Terminology' part, I can't select value of Request Changes / Approve/ Release. Is this ok for now?

It is ok to delete and re-add the modified value, instead of needing to edit it.

IanMayo commented 16 hours ago

@Tristina1788 - can we have a final check of this PR please?

Tristina1788 commented 15 hours ago

@Tristina1788 - can we have a final check of this PR please?

@IanMayo I checked and comment here : https://github.com/serge-web/serge/issues/2947#issuecomment-2238735606