serge-web / serge

Serious Gaming, Evolved - web interface
https://sites.google.com/deepbluec.com/serge/
Apache License 2.0
14 stars 4 forks source link

2975 design templates with multiple items per row #2984

Closed lilitkarapetyan closed 2 weeks ago

lilitkarapetyan commented 1 month ago

Fixes #2975

🧰 Issue

πŸš€ Overview:

πŸ”— Link to preview

πŸ€” Reason:

πŸ”¨Work carried out:

πŸ–₯️ Screenshot

Confirmations

πŸ“ Developer Notes:

IanMayo commented 1 month ago

@lilitkarapetyan - could you include a video of editing a template to put them in one row, and then the player seeing that template please?

Tristina1788 commented 1 month ago

@lilitkarapetyan @IanMayo Now I can adjust for size field but I still don't see anywhere to config multiple fields on same row : https://app.screencast.com/89TPv8aLW4GcQ

IanMayo commented 1 month ago

@lilitkarapetyan @IanMayo Now I can adjust for size field but I still don't see anywhere to config multiple fields on same row : https://app.screencast.com/89TPv8aLW4GcQ

Yes @Tristina1788 , we're part way there :-D. Note: you should be able to verify the layout from the "template preview" tab of the template editor.

IanMayo commented 1 month ago

@lilitkarapetyan - can you check one thing please? When we are designing the template, and we switch to preview, and then back to edit - can you check the original attribute name is there?

Tristina1788 commented 1 month ago

@lilitkarapetyan - can you check one thing please? When we are designing the template, and we switch to preview, and then back to edit - can you check the original attribute name is there?

Is that about params of element? Seem it's ok on my checking : https://app.screencast.com/9gWnCx4du8aJn

Tristina1788 commented 1 month ago

@lilitkarapetyan @IanMayo Now I can see multiple fields are on the same row. But how to make any field is not same row? Seem now all fields are same rows until no left space.

image

lilitkarapetyan commented 1 month ago

@lilitkarapetyan @IanMayo Now I can see multiple fields are on the same row. But how to make any field is not same row? Seem now all fields are same rows until no left space.

image

You need to change the column size. ahh, the size of the input field does not increase completely. I will investigate now

Tristina1788 commented 1 month ago

@lilitkarapetyan @IanMayo I still don't have the way to put the item down to new line as my expected . Currently the new item will be down to new line when the total size of items are 12.

image

@lilitkarapetyan Can you guide me the way to have the form below ( I draw form by paint, not from our form builder)

image

lilitkarapetyan commented 1 month ago

@lilitkarapetyan @IanMayo I still don't have the way to put the item down to new line as my expected . Currently the new item will be down to new line when the total size of items are 12.

image

@lilitkarapetyan Can you guide me the way to have the form below ( I draw form by paint, not from our form builder)

image

Wen you adjust the with of column from 1 to 12 (0% to 100%). if the items cannot fit in one row, the item on the right moves down to the next row.

lilitkarapetyan commented 1 month ago

this lib we are using doesn't have taht feature by default, I added it myself

lilitkarapetyan commented 1 month ago

This lib we are using doesn't have taht feature by default, I added it myself

Tristina1788 commented 4 weeks ago

This lib we are using doesn't have taht feature by default, I added it myself

@lilitkarapetyan I think we need to improve for user can custom about the size of input field and input field in the new line when he want. @IanMayo How do you think

IanMayo commented 2 weeks ago

Let me understand how things work:

That seems ok for me @Tristina1788 .

Tristina1788 commented 2 weeks ago

Let me understand how things work:

  • the form designer specifies the field width, in 12ths.
  • the fields get laid out with the specified width, wrapping to new line once the value goes past 12. Is that right @lilitkarapetyan

That seems ok for me @Tristina1788 .

@IanMayo I mean we can't custom it whatever we want. Example we can't create this below form. Is this ok?

image

IanMayo commented 2 weeks ago

Let me understand how things work:

  • the form designer specifies the field width, in 12ths.
  • the fields get laid out with the specified width, wrapping to new line once the value goes past 12. Is that right @lilitkarapetyan

That seems ok for me @Tristina1788 .

@IanMayo I mean we can't custom it whatever we want. Example we can't create this below form. Is this ok?

Aaah, I see. We can't create layout that has white-space to the right of the controls. The main problem for game designers is in creating a really compact form that still contains all of the fields. I don't believe there is the case where the designer wants to introduce white-space.

The inability to insert white space is not an issue for me. If that is the only remaining issue then I'm happy to go with this solution.

Tristina1788 commented 2 weeks ago

Let me understand how things work:

  • the form designer specifies the field width, in 12ths.
  • the fields get laid out with the specified width, wrapping to new line once the value goes past 12. Is that right @lilitkarapetyan

That seems ok for me @Tristina1788 .

@IanMayo I mean we can't custom it whatever we want. Example we can't create this below form. Is this ok?

Aaah, I see. We can't create layout that has white-space to the right of the controls. The main problem for game designers is in creating a really compact form that still contains all of the fields. I don't believe there is the case where the designer wants to introduce white-space.

The inability to insert white space is not an issue for me. If that is the only remaining issue then I'm happy to go with this solution.

Yeah, so It's ok to close this PR.