2769 eliminate ts ignore in admin game setup component

lilitkarapetyan commented 2 weeks ago

Fixes #2769

🧰 Issue

🚀 Overview:

🔗 Link to preview

🤔 Reason:

🔨Work carried out:

[x] Tests pass

🖥️ Screenshot

Confirmations

[ ] I have chosen reviewers for my PR.
[ ] I have assigned myself to this PR.
[ ] I have chosen an appropriate label for the PR.
[ ] I have completed the mandatory sections of this document.
[ ] I have deleted any unused sections.
[ ] I confirm that I have checked for required README updates and acted accordingly.

📝 Developer Notes:

Tristina1788 commented 2 weeks ago

@lilitkarapetyan @IanMayo I see the failed tests then I checkout and check from my side. I can run pass without any issue. So I re-run the job and the tests from deployment are also passed. The failed test before maybe from low connection. But I don't know what I should check in this PR. From UI, seems everything is working as before.

IanMayo commented 2 weeks ago

But I don't know what I should check in this PR. From UI, seems everything is working as before.

Hello @Tristina1788 - this is a code change that should not change the UI functionality. So, everything should work as before - so that's a good sign :-)

IanMayo commented 2 weeks ago

We have these build errors @lilitkarapetyan. I tried the apply the suggested fix, but I don't think it worked:

       src/ActionsAndReducers/dbMessageTypes/messageTypes_ActionCreators.ts(3,19): error TS7016: Could not find a declaration file for module 'check-types'. '/tmp/build_0e601687/client/node_modules/check-types/src/check-types.js' implicitly has an 'any' type.
         Try `npm i --save-dev @types/check-types` if it exists or add a new declaration (.d.ts) file containing `declare module 'check-types';`
       src/ActionsAndReducers/dbMessages/messages_ActionCreators.ts(4,19): error TS7016: Could not find a declaration file for module 'check-types'. '/tmp/build_0e601687/client/node_modules/check-types/src/check-types.js' implicitly has an 'any' type.
         Try `npm i --save-dev @types/check-types` if it exists or add a new declaration (.d.ts) file containing `declare module 'check-types';`

I'll have to leave it to you, please.

lilitkarapetyan commented 2 weeks ago

We have these build errors @lilitkarapetyan. I tried the apply the suggested fix, but I don't think it worked:

       src/ActionsAndReducers/dbMessageTypes/messageTypes_ActionCreators.ts(3,19): error TS7016: Could not find a declaration file for module 'check-types'. '/tmp/build_0e601687/client/node_modules/check-types/src/check-types.js' implicitly has an 'any' type.
         Try `npm i --save-dev @types/check-types` if it exists or add a new declaration (.d.ts) file containing `declare module 'check-types';`
       src/ActionsAndReducers/dbMessages/messages_ActionCreators.ts(4,19): error TS7016: Could not find a declaration file for module 'check-types'. '/tmp/build_0e601687/client/node_modules/check-types/src/check-types.js' implicitly has an 'any' type.
         Try `npm i --save-dev @types/check-types` if it exists or add a new declaration (.d.ts) file containing `declare module 'check-types';`

I'll have to leave it to you, please.

I will solove it

lilitkarapetyan commented 2 weeks ago

Did you run the yarn command ?

IanMayo commented 2 weeks ago

Did you run the yarn command ?

The error comes from the Heroku build, not my local machine. Running yarn install locally fixed my build, but we need the Heroku build to run, too.

IanMayo commented 1 week ago

Hello @lilitkarapetyan - this is done, really. But, how about you try to remove some other ts-ignore comments in the code base, too?

lilitkarapetyan commented 1 week ago

Hello @lilitkarapetyan - this is done, really. But, how about you try to remove some other ts-ignore comments in the code base, too?

I Think It's good Idea

IanMayo commented 6 days ago

This is good work, thanks @lilitkarapetyan

It seems to cover quite a wide area, so it's worth @Tristina1788 doing some wider testing. @lilitkarapetyan - could you please provide a list of areas of Serge that should be re-tested due to changes in this PR?

lilitkarapetyan commented 5 days ago

This is good work, thanks @lilitkarapetyan

It seems to cover quite a wide area, so it's worth @Tristina1788 doing some wider testing. @lilitkarapetyan - could you please provide a list of areas of Serge that should be re-tested due to changes in this PR?

Hello , I think you could test keeping the Forces Save section in the admin panel and the Chanel tab in the game. Screenshot (303) Screenshot (304)

Tristina1788 commented 5 days ago

@IanMayo @lilitkarapetyan Checking all places and I don't see the difference with before.

IanMayo commented 5 days ago

I don't see the difference with before.

Good, that's what we're hoping to see 🤣 . Lilit has done some tidying (refactoring) of the source code for Serge, but the test is that nothing has been broken. So, that's what we're looking for @Tristina1788 .

lilitkarapetyan commented 5 days ago

@IanMayo @lilitkarapetyan Checking all places and I don't see the difference with before.

Yes, we need it to work like before.

Tristina1788 commented 5 days ago

I don't see the difference with before.

Good, that's what we're hoping to see 🤣 . Lilit has done some tidying (refactoring) of the source code for Serge, but the test is that nothing has been broken. So, that's what we're looking for @Tristina1788 .

Yes, I understand that. So It's good to go.

serge-web / serge