search

serge-web / serge

Serious Gaming, Evolved - web interface
https://sites.google.com/deepbluec.com/serge/
Apache License 2.0
15 stars 4 forks source link

'yarn build' should not start server #937

Open IanMayo opened 3 years ago

IanMayo commented 3 years ago

I've spotted something strange :wink:

I believe yarn build is used to compile the application, ready for deployment.

But when I run yarn build it starts up the server, and opens localhost:3000. I'm nervous that starting the server could cause problems when we create a build with yarn pkg-build or when a Heroku deployment is being run.

I only expected the server to run from yarn develop.

Could you investigate the build commands please?

phileba commented 3 years ago

It seems this issue does not happen on my machine this time, but I confirm that sometimes I can see it start the server when doing the yarn build 🤔

IanMayo commented 3 years ago

Aah, it's not happening for me either, now. Hmm.

lebaphi commented 3 years ago

Note that I have seen this issue appear sometime recently

IanMayo commented 3 years ago

I've just run yarn build and it's not being spawned at the moment. If you see an instance of it, @lebaphi - please attach a screenshot of the command line - as a clue for what the problem is.