Closed schultetwin1 closed 3 years ago
@serge1 if you aren't interested in this change feel free to close it. My main goal is to be able to include ELFIO as a package in vcpkg to make it easier for downstream consumers to use ELFIO.
Thank you for your submission! I will look at it soon
Hi Matt, I definetly accept your changes - they are very beneficial for the library. Thank you!
When using GNU make generator, do you know what should be configured to have 'make check' working together (or instead of) 'make test'?
Hi Matt, I definetly accept your changes - they are very beneficial for the library. Thank you!
When using GNU make generator, do you know what should be configured to have 'make check' working together (or instead of) 'make test'?
I do! I just created #51 to do that
This change adds an install step to the CMake build system. This will allow other users of CMake to easily integrate ELFIO with their projects without any extra work. This is also the first step to be able to distribute ELFIO via vcpkg.
The benefit of this is, after building using CMake and then running
make install
withELFIO
users of CMake can then use the following CMake to easily pull in ELFIO.List of changes
CMAKE_CXX_STANDARD
to 17. elfio headers do not require C++17.elfio
target, which properly sets up header include paths for the examples and testselfio
target to be used by external consumers of elfioctest
(so you can runmake
and thenmake test
)