sergey-dryabzhinsky / nginx-rtmp-module

NGINX-based Media Streaming Server
http://nginx-rtmp.blogspot.com
BSD 2-Clause "Simplified" License
1.02k stars 218 forks source link

Add support for bandwidth detection #90

Open sergey-dryabzhinsky opened 8 years ago

sergey-dryabzhinsky commented 8 years ago

Something like:

Api must be like: http://www.codebelt.com/actionscript-3/as3-onbwdone-error-flash-media-server-with-amazon-cloudfront/

sergey-dryabzhinsky commented 8 years ago

Need help with check new-module-bandwidth-detection branch. It's based on Red5 plugin. Need flash client that can check BW.

sergey-dryabzhinsky commented 8 years ago

Still no luck. Can't do right call for onBWCheck and onBWDone. Wander how it doing Wowza + plugin. Need wireshark dump. Or tcpdump.

mbeacom commented 8 years ago

@sergey-dryabzhinsky I'll see if I can get a wireshark dump this evening and post a gist.

winkmichael commented 8 years ago

Got an RTMP URL we can setup a player / link that does the test?

chriswiggins commented 8 years ago

I can test with my dev version of Wowza and capture the packets if you like @sergey-dryabzhinsky

sergey-dryabzhinsky commented 8 years ago

@chriswiggins That would be nice

lavvy commented 8 years ago

+1 On Apr 15, 2016 12:55 AM, "Sergey" notifications@github.com wrote:

@chriswiggins https://github.com/chriswiggins That would be nice

— You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub https://github.com/sergey-dryabzhinsky/nginx-rtmp-module/issues/90#issuecomment-210287639

chriswiggins commented 8 years ago

@sergey-dryabzhinsky have emailed you a PCAP file with the data in it. Please let us know how you get on :+1:

sergey-dryabzhinsky commented 8 years ago

Well, the main difference is:

  1. 'payload' data:

    • wowza send array(double)[1800]
    • my code send string[16kb]

    But it sends empty string in first message, so there should be no error with my code I think

  2. wowza starts checking right after connection. I'll try to make similar behaviour.
sergey-dryabzhinsky commented 8 years ago

Updated branch 'new-module-bandwidth-detection':

sergey-dryabzhinsky commented 8 years ago

Here some description on options (app level) with default values:

Any naming suggestions are welcome.

sergey-dryabzhinsky commented 8 years ago

Probably prefix bw_ needed.

sergey-dryabzhinsky commented 8 years ago

Options names changed:

chriswiggins commented 8 years ago

@sergey-dryabzhinsky how are you getting on with this?

What benefit does bandwidth detection give us?

sergey-dryabzhinsky commented 8 years ago

@chriswiggins If you have several servers (regional for example) you can connect to each, check latency, bandwidth and choose fastest.

lavvy commented 8 years ago

+1 On Apr 20, 2016 7:18 PM, "Sergey" notifications@github.com wrote:

@chriswiggins https://github.com/chriswiggins If you have several servers (regional for example) you can connect to each, check latency and choose fastest.

— You are receiving this because you commented. Reply to this email directly or view it on GitHub https://github.com/sergey-dryabzhinsky/nginx-rtmp-module/issues/90#issuecomment-212649383

chriswiggins commented 8 years ago

Ah right ok nice. Understand the importance then! 👍

sergey-dryabzhinsky commented 7 years ago

Still not tested. Need to build some simple flash test app.