search

sergey-dryabzhinsky / qt-webkit-kiosk

This is simple browser application written on Qt & QtWebkit.
57 stars 37 forks source link

Fix keys #32

Closed HED-jzignego closed 4 years ago

HED-jzignego commented 4 years ago

The first commit fixes an issue where if you weren't running with a window manager, and you set that config to true, the screen would go black and stay black (there are no other windows) after that callback fires

The third commit fixes an issue where if you weren't running with a window manager, and also had no touchscreen and no mouse, the outer mainwindow always had keyboard focus, so the web app couldn't see any keydown events, and since you had no mouse or touchscreen you couldn't grab the focus to the view.

therealjumbo commented 4 years ago

I could remove the scrollUp and scrollDown and pageUp and pageDown case statements and functions too, since I the view knows how to handle those correctly.

EDIT: same person, just my other username, sorry for the confusion.

therealjumbo commented 4 years ago

@sergey-dryabzhinsky is this repo still active?

sergey-dryabzhinsky commented 4 years ago

Hi @therealjumbo That changes are not affect behaviour with window manager? Do you test this?

therealjumbo commented 4 years ago

I tested it on the hardware I have available... I'm not using a window manager like X on my hardware. So I can't really test that scenario.

sergey-dryabzhinsky commented 4 years ago

Seems like there no errors. Thanks for request.