Fixed `axios` vulnerability reported by `npm audit`, updated dependencies, made 100% test coverage

sergey-telpuk / nestjs-rbac

Awesome RBAC for NestJs

Other

421 stars 36 forks source link

Fixed `axios` vulnerability reported by `npm audit`, updated dependencies, made 100% test coverage #68

Closed mrauhu closed 3 years ago

mrauhu commented 3 years ago

Hello, @sergey-telpuk

List of changes:

Fixed lint errors
Created E2E test Should return 200 because user have permission4, for 100% code coverage
Removed the unused E2E test6, because we check admin permissions via test 5
Updated dependencies and dev dependencies. Fixed axios vulnerability reported by npm audit
Changed coverage directory path in .gitignore

Best wishes, Sergey.

sergey-telpuk commented 3 years ago

Hello, @sergey-telpuk

List of changes:

Fixed lint errors

Created E2E test Should return 200 because user have permission4, for 100% code coverage

Removed the unused E2E test6, because we check admin permissions via test 5

Updated dependencies and dev dependencies. Fixed axios vulnerability reported by npm audit

Changed coverage directory path in .gitignore

Best wishes, Sergey.

Hi @mrauhu thanks for PR, It'll be merged.