search

sergey-tihon / Clippit

Fresh PowerTools for OpenXml
https://sergey-tihon.github.io/Clippit/
MIT License
50 stars 19 forks source link

DocumentAssembler: Support for images #31

Closed michha closed 3 years ago

michha commented 3 years ago

In our organisation we use a custom Clippit version, where we took a Pull Request for the Open-Xml-PowerTools and applied it on Clippit. I want to bring this feature to Clippit, so everyone can use it.

sergey-tihon commented 3 years ago

Thank you for this PR @michha !

Can you please briefly describe the feature here or add new docs page if it bring new API/capability. I do my best to document all significant changes.

michha commented 3 years ago

First I want to line out, that this contribution is not our own but from user @krembf that he tried to get into the Microsoft repo back in 2018 (see DocumentAssembler: Support for Images (#42) #236). In December 2020 user @carzaza tried to get this changes into the fork from Eric White (see DocumentAssembler: Support for images #30).

Because of holidays it will take me some weeks to get a new docs page.

sergey-tihon commented 3 years ago

I've released code from this branch in v1.7.0-beta1 @michha can you please try it and confirm that it works for you?

krembf commented 3 years ago

Thanks for mentioning me, @michha! In case this would be of any help with documentation, I'm attaching some details of the implementation (extracted from the conversation I had with the original owner of the PowerTools. SupportForImages.docx

michha commented 3 years ago

I've released code from this branch in v1.7.0-beta1 @michha can you please try it and confirm that it works for you?

Our use cases are working with the beta release 👍

sergey-tihon commented 3 years ago

I've released it as v1.7.0 but it will be nice to add more docs for this as separate PR.