search

sergeyklay / bnf-mode

A GNU Emacs major mode for editing BNF grammars
GNU General Public License v3.0
45 stars 9 forks source link

Removing the use of pkg-info #1

Closed sergeyklay closed 5 years ago

sergeyklay commented 5 years ago

Thanks - merging now!

BTW, I strongly recommend removing the use of pkg-info and particularly the bnf-mode-version function, which is almost the biggest piece of code in this little package. Users can easily call describe-package (built-in) or pkg-info-package-version interactively if they want to get this information.

Originally posted by @purcell in https://github.com/melpa/melpa/pull/6074#issuecomment-475916422

sboosali commented 5 years ago

iiuc, why not provide an defalias for pkg-info-package-version?

like

(defalias 'bnf-mode-version #'pkg-info-package-version)
sboosali commented 5 years ago

(anecdotally, i write a lot of elisp, and didn't know about pkg-info-package-version until now. yesterday, i tried running use-package-version.)

sergeyklay commented 5 years ago

Frankly speaking, I can't find a compelling reason to duplicate this functionality.