search

sergeyklay / php-orm-benchmark

The benchmark to compare performance of PHP ORM solutions.
MIT License
81 stars 7 forks source link

Move to separate folder #12

Closed harikt closed 6 years ago

harikt commented 6 years ago

Partially fixed https://github.com/sergeyklay/php-orm-benchmark/issues/10 .

The docker file need to be updated.

I am not familiar with it.

I think probably each repo should contain a separate docker file for the phalcon extension is not needed for the rest.

harikt commented 6 years ago

May be we need to run benchmarks on travis ;) .

sergeyklay commented 6 years ago

@harikt Absolutely. With Travis CI we don't need to launch Docker.

sergeyklay commented 6 years ago

Thank you

harikt commented 6 years ago

@sergeyklay this is not fully done or may be broken on docker. May be you need to verify the same .

harikt commented 6 years ago

I actually noticed one thing. I have accidentally commited something that I have been trying to benchmark :P . I hope I can send a PR if I fix the same in the coming days.

sergeyklay commented 6 years ago

Don't worry 😉 Take your time. I'm ok with this