Open fbuchmeier-abi opened 11 months ago
@fbuchmeier-abi Hello! Thanks for your PR. I will look on it and merge during next week
Hi @sergeyshevch ,
any news on the PR? Is there anything I can change / do?
Thanks! Florian.
Hi @sergeyshevch,
any news from your side? Can I support you in any way?
Best regards, Florian.
Summary
Hi @sergeyshevch, I've made some fixes to your statuspage-exporter and the Helm Chart. I've also updated the client_timeout setting to use seconds instead of nanoseconds.
It would be great if you could take a look at the changes and give me feedback.
Thanks! Florian.
Version 3.0.0
⚠ BREAKING CHANGE
Features
Fixes
Details
Use correct port name for readiness and liveness probes, use correct endpoint to get health status
wrong port in Helm Chart:
wrong endpoints in Helm Chart:
https://github.com/sergeyshevch/statuspage-exporter/blob/main/main.go#L40
Use seconds instead of nanoseconds for client_timeout for easier usability
Looking at the example config file, I suppose
seconds
where always the intended unit instead of nano-seconds:https://pkg.go.dev/github.com/go-resty/resty#SetTimeout
https://pkg.go.dev/time#Duration
Status getting mapped correctly
Beforce
After