search

sergeyt / meteor-typeahead

Autocomplete package for meteor powered by twitter typeahead.js
https://atmospherejs.com/sergeyt/typeahead
MIT License
146 stars 82 forks source link

Breaks with meteor release 1.2.0.1 #112

Closed shapiromatron closed 9 years ago

shapiromatron commented 9 years ago

After updating the demo to version 1.2.0.1 of meteor, I'm getting some breaking errors upon page initialization:

8meteor.js:880 Exception in template helper: Error: There is no current view
    at Object.Blaze._getCurrentView (http://127.0.0.1:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:2485:11)
    at Object.Blaze.getView (http://127.0.0.1:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:2466:18)
    at Object.Blaze.getData (http://127.0.0.1:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:2420:21)
    at null.<anonymous> (http://127.0.0.1:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:2983:24)
    at null.<anonymous> (http://127.0.0.1:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:1650:16)
    at http://127.0.0.1:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:3038:66
    at Function.Template._withTemplateInstanceFunc (http://127.0.0.1:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:3671:12)
    at null.<anonymous> (http://127.0.0.1:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:3037:27)
    at http://127.0.0.1:3000/packages/sergeyt_typeahead.js?038c79aec312bbc83241b738e196f6c9f3e3f0bf:2820:27
    at Function.Template._withTemplateInstanceFunc (http://127.0.0.1:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:3671:12)
sergeyt_typeahead.js:2639 TypeError: Cannot read property 'value' of undefined(…)
ciwolsey commented 9 years ago

I'm having this problem too. My console output is slightly different:

Exception in template helper: Error: There is no current view
    at Object.Blaze._getCurrentView (http://dev.wolsey.org:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:2485:11)
    at Object.Blaze.getView (http://dev.wolsey.org:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:2466:18)
    at Object.Blaze.getData (http://dev.wolsey.org:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:2420:21)
    at bindDataContext (http://dev.wolsey.org:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:2983:24)
    at Blaze._wrapCatchingExceptions (http://dev.wolsey.org:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:1650:16)
    at http://dev.wolsey.org:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:3038:66
    at Function.Template._withTemplateInstanceFunc (http://dev.wolsey.org:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:3671:12)
    at wrapHelper (http://dev.wolsey.org:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:3037:27)
    at http://dev.wolsey.org:3000/packages/sergeyt_typeahead.js?038c79aec312bbc83241b738e196f6c9f3e3f0bf:2820:27
    at Function.Template._withTemplateInstanceFunc (http://dev.wolsey.org:3000/packages/blaze.js?9391df93ba5076c2cfc61ee68724eb79b65f00d9:3671:12)
andregoldstein commented 9 years ago

Also.

carlosacp commented 9 years ago

me too :(

ghost commented 9 years ago

Same here.

mbreuer23 commented 9 years ago

same here.

ghost commented 9 years ago

same here.

babnik63 commented 9 years ago

and here :-(

sergeyt commented 9 years ago

This package uses internal meteor API, and it seems this API changed. I guess Template._withTemplateInstanceFunc needs to be bind to view resolved before in resolve_template_function. I'll try to fix it this weekend. Sorry I am too busy now.

ghost commented 9 years ago

@sergeyt Thanks for the update. Will wait for that then. +1

babnik63 commented 9 years ago

We all wait, take your time. Thanks Sergey

shapiromatron commented 9 years ago

Thanks @sergeyt, totally understand. Just wanted to make sure you were aware of the issue and I could replicate in the test-suite.

andregoldstein commented 9 years ago

Thanks for taking a look Sergey. On 30 Sep 2015 05:18, "Andy Shapiro" notifications@github.com wrote:

Thanks @sergeyt https://github.com/sergeyt, totally understand. Just wanted to make sure you were aware of the issue and I could replicate in the test-suite.

— Reply to this email directly or view it on GitHub https://github.com/sergeyt/meteor-typeahead/issues/112#issuecomment-144277099 .

joaobarcia commented 9 years ago

Thanks

ghost commented 9 years ago

Thanks @sergeyt . Looking forward to pulling the new update after the weekend!

sergeyt commented 9 years ago

published v0.11.1_5 with the fix of this issue, please check it out

croustibat65 commented 9 years ago

Thanks!

sergeyt commented 9 years ago

please close the issue if the fix works, I've checked it in demo app with METEOR@1.2.0.2

ciwolsey commented 9 years ago

I'm gonna check this right away Sergey. Thanks!

ghost commented 9 years ago

Working for me. +1

shapiromatron commented 9 years ago

Works for me too; I tried the demo app and confirm that all tests are working using meteor v1.2.0.2. Thanks for the quick fix @sergeyt!

ciwolsey commented 9 years ago

Yep it's all good

jchan202 commented 9 years ago

Thanks @sergeyt!