sergiitk / pagerbeauty

:pager::sparkles: PagerDuty on-call widget for monitoring dashboard. Datadog and Grafana compatible

https://demo.pagerbeauty.sergii.org/v1/schedules/PDUQGYJ.html

MIT License

338 stars 27 forks source link

Added additional information about user on each schedule view: phone … #126

Closed suhomozgy-andrey closed 4 years ago

suhomozgy-andrey commented 4 years ago

What's this PR do?

In this PR I added an additional request for user contact methods. To display user phone on each schedule page. It would be useful for example for peoples who don't have access to PagerDuty, but they should see user phone for any emergency case.

How should this be manually tested?

On each schedule panel user, the phone should appear if user have at least one phone contact method

Example screenshot

What are the relevant tickets?

Fixes #125

codecov[bot] commented 4 years ago

Codecov Report

Merging #126 into master will not change coverage. The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #126   +/-   ##
======================================
  Coverage    7.27%   7.27%           
======================================
  Files          22      22           
  Lines         522     522           
======================================
  Hits           38      38           
  Misses        484     484

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 99f3817...3fde365. Read the comment docs.

sergiitk commented 4 years ago

Thank you for your contribution! I'm planning to get some work in next week, will review this and get it merged as well.

suhomozgy-andrey commented 4 years ago

@sergiitk sure. will add a key for that

sergiitk commented 4 years ago

:tada: This PR is included in version 1.1.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: