search

sergiocorreia / panflute

An Pythonic alternative to John MacFarlane's pandocfilters, with extra helper functions
http://scorreia.com/software/panflute/
BSD 3-Clause "New" or "Revised" License
500 stars 59 forks source link

Added fix for unstable element index (issue #223) #224

Closed erbsenmann closed 2 years ago

erbsenmann commented 2 years ago

Hi, I solved the issue described in #223 using this patch locally. With this adaption I was able to run my filter as expected. Also added a smaller test than in the ticket.

Idea is to fill the index position in the ListContainer along with the parent and location instead of deriving it. Like this eq on element can be left untouched.

ickc commented 2 years ago

is it possible to do a minor edit to the version.py file and bump it to 2.2.5?

I'd advise against this as so far this PR is standalone about 1 issue. Version bumping is about releasing a package which is not part of this issue or PR's job.

Put it in other words, it would be confusing if all PRs are asked to bump the version because it is possible that only after a few PRs there's a version release. And since that cannot be asked to all PRs, it is equally confusing to just ask some of them doing it.

sergiocorreia commented 2 years ago

Fair enough!