search

sergiodxa / remix-auth-github

A GitHubStrategy for Remix Auth, based on the OAuth2Strategy
https://sergiodxa.github.io/remix-auth-github/
MIT License
75 stars 17 forks source link

Issue with async call in documentation #1

Closed dinolunch closed 5 days ago

dinolunch commented 2 years ago

When attempting to use the strategy as documented I'm getting the following error:

Argument of type '(accessToken: any, _: any, extraParams: any, profile: any) => Promise' is not assignable to parameter of type 'StrategyVerifyCallback<any, OAuth2StrategyVerifyParams<GitHubProfile, GitHubExtraParams>>'.

dinolunch commented 2 years ago

Also, appears to be an issue with authenticator.use(gitHubStrategy). Seeing the following error:

Argument of type 'GitHubStrategy' is not assignable to parameter of type 'Strategy<User, never>'. Types of property 'verify' are incompatible. Type 'StrategyVerifyCallback<unknown, OAuth2StrategyVerifyParams<GitHubProfile, GitHubExtraParams>>' is not assignable to type 'StrategyVerifyCallback<User, never>'. Type 'unknown' is not assignable to type 'User'.ts(2345)

loke-dev commented 2 years ago

I have the same issues when trying to upgrade from version 2