Add support to customize the scope

sergiodxa / remix-auth-oauth2

A OAuth2Strategy for Remix Auth

https://sergiodxa.github.io/remix-auth-oauth2/

MIT License

150 stars 56 forks source link

Closed mr-menno closed 3 months ago

mr-menno commented 1 year ago

added support for optional scope attribute for #50

mr-menno commented 1 year ago

Other option is to possibly update this PR to make the scope option empty be default and only add it if it has a value.

Fixed that in my second commit.

sergiodxa commented 1 year ago

@mr-menno do you think you can add a test for this? a simpler one creating the strategy with a custom scope and check the scope is applied.

mr-menno commented 1 year ago

Honestly, I'm not good at writing tests.

sergiodxa commented 3 months ago

Support for this was implemented in #89