search

sergiodxa / remix-auth

Simple Authentication for Remix
MIT License
1.94k stars 112 forks source link

Resolved CI Linter and Unit and Integration Tests failures #246

Closed aydrian closed 11 months ago

aydrian commented 11 months ago

Should unblock release for #243

I only upgraded the dependencies required to resolve the issues. I updated @remix-run/server-runtime to ^2.0.1, this required me to upgrade Jest in order to handle node:crypto no longer being polyfilled in @remix-run/node. The url passed to new Requests in tests had to be updated to fit new validation. I also had to change the way we test thrown responses due to the returned object not deeply matching anymore. Now instead checking to make sure error thrown is an instance of Response and then checking that the status and message are what's expected.

aydrian commented 11 months ago

I noticed the CI failed again. Could this be due to it running Node v14?

aydrian commented 11 months ago

Added PR #247 to hopefully resolve the remaining issues.