search

sergiogonzalez / google-login-hook

Google Login Hook
GNU Lesser General Public License v2.1
5 stars 10 forks source link

url prefix - failure #2

Open isitaram opened 10 years ago

isitaram commented 10 years ago

We have /liferay prefix (context root) for one of our sites. Google login fails due to this. Please add the prefix while redirecting.

Example - The redirect URI in the request: http://www.testdc.us/c/portal/google_login?cmd=token did not match a registered redirect URI

It should have been - http://www.testdc.us/liferay/c/portal/google_login?cmd=token

https://accounts.google.com/o/oauth2/auth?access_type=online&approval_prompt=force&client_id=198990984173-o05rjf8l7d9r50c1g1ea405oorpkei0g.apps.googleusercontent.com&redirect_uri=http://www.testdc.us/c/portal/google_login?cmd%3Dtoken&response_type=code&scope=https://www.googleapis.com/auth/userinfo.email%20https://www.googleapis.com/auth/userinfo.profile

Gentarn commented 9 years ago

I have same above issue google login redirect doesn't work . If you had already fix this issue , will you inform please!

ctliv commented 9 years ago

I have exactly same issue described above. I got Liferay image from Bitnami, which installs Liferay under "/liferay" path, not under root.

fbudassi commented 9 years ago

Have you tried with the official google-login-hook which is included in the liferay-plugins project? It is a fork of this project but is supposed to be up to date.

You can check it out at: https://github.com/liferay/liferay-plugins/tree/master/hooks/google-login-hook

Be sure to choose the right branch, because master is for Liferay 7.

ctliv commented 9 years ago

Thanks a lot! (Anzi, leggendo il nome, grazie...)

I was not aware of this repository. It is not listed in official Liferay Download page (where just the Plugins SDK, that does not contain any buildable plugin, can be downloaded). Nor these hooks are in the Marketplace. Moreover, as far as I have seen those hooks are not included in any bundle.

Are they "official"? Is there a place where I can download the WAR instead of the source for build?

Thanks for helping, again.

2015-08-26 17:56 GMT+02:00 Federico Budassi notifications@github.com:

Have you tried with the official google-login-hook which is included in the liferay-plugins project? It is a fork of this project but is supposed to be up to date.

You can check it out at: https://github.com/liferay/liferay-plugins/tree/master/hooks/google-login-hook

Be sure to choose the right branch, because master is for Liferay 7.

— Reply to this email directly or view it on GitHub https://github.com/sergiogonzalez/google-login-hook/issues/2#issuecomment-135078444 .

fbudassi commented 9 years ago

You're welcome, ctliv (though I'm not Italian, but Argentinian... most of my ancestors were)

They seem to be official... or at least they are maintained by Liferay Inc.

I haven't been able to grab a pre-built war, and in the marketplace you can only find the original one made by Sergio Gonzalez (who seems to be a Liferay employee now). When I had to use it, I cloned the liferay-plugins repo and built it from there. Besides, I needed some changes, so I forked it and updated some parts because it didn't support the changes introduced by Google during 2014 (see the pull request with the changes: https://github.com/liferay/liferay-plugins/pull/173)

That's pretty much what I can tell you... just get the (huge) repo and compile it on your own.

Regards.

ctliv commented 9 years ago

Ok. Actually, the Liferay-plugin repository says "Most of the plugins found in the liferay-plugins repository can be easily installed on Liferay Portal via Liferay Marketplace. To build one or more of the plugins yourself, read below for details". The hook is not in Marketplace, so I have to build it, too...

Before downloading this huge repo, I'd need to know if the issue due to changes introduced by Google during 2014 is solved.

There are several comments in the repo referring to issue https://issues.liferay.com/browse/LPS-54754, which could mean that your changes have been incorporated, but the issue itself states that code is still in "Ready for QA" and "Unresolved" for versions "6.2.X EE, Master". As "Master" is version 7, is now the branch "6.2.x" of the "google-login-hook" updated to solve Google Login issue for Liferay Portal 6.2 CE?

Regards.

2015-08-27 16:20 GMT+02:00 Federico Budassi notifications@github.com:

You're welcome, ctliv (though I'm not Italian, but Argentinian... most of my ancestors were)

I haven't been able to grab a pre-built war, and in the marketplace you can only find the original one made by Sergio Gonzalez (who seems to be a Liferay employee now). When I had to use it, I cloned the liferay-plugins repo and built it from there. Besides, I needed some changes, so I forked it and updated some parts because it didn't support the changes introduced by Google during 2014 (see the pull request with the changes: liferay/liferay-plugins#173 https://github.com/liferay/liferay-plugins/pull/173)

That's pretty much what I can tell you... just get the (huge) repo and compile it on your own.

Regards.

— Reply to this email directly or view it on GitHub https://github.com/sergiogonzalez/google-login-hook/issues/2#issuecomment-135450163 .

fbudassi commented 9 years ago

My changes were incorporated some months ago at least to branch 6.2.x. I know it because I've been using a war compiled from the official liferay-plugins repo (and not from my fork), and it's been in a production system for about two months now. So, I would say that you can trust branch 6.2.x.

I don't know about master, but after a quick check at the code, I would say they have also merged my changes into that branch as well.

What I believe that is happening with https://issues.liferay.com/browse/LPS-54754 is that they have not tested those changes yet. Sometimes Liferay takes a really long time to resolve issues.

Regards, Federico.