search

sergiokopplin / indigo

Minimalist Jekyll Template, dark and light themes
https://sergiokopplin.github.io/indigo/
2.63k stars 2.29k forks source link

Dark Theme #439

Closed heychirag closed 2 years ago

heychirag commented 4 years ago

Support for dark theme as this is the new fad.

sergiokopplin commented 4 years ago

I've done some changes in a branch locally, but it needs some refactor. I'll push it later, then we can work together on that

Nazeeefa commented 4 years ago

Thanks @sergiokopplin! Option to switch from light to dark theme would be great and useful!

notSeaSmoke commented 3 years ago

Any updates on this?

sergiokopplin commented 3 years ago

Hey Guys! I was thinking about it. Have you guys tried the Dark Read for Chrome? It seems a good theme colour to apply in a dark mode.

Nazeeefa commented 3 years ago

Do you mean the Chrome extension https://darkreader.org/ ? :) Yes, it has a nice dark colour. It would be nicer to have button in indigo theme that allows to switch between dark and light.

notSeaSmoke commented 3 years ago

Having a native dark mode integration on the site itself is better than using an extension, especially considering that most mobile browsers don't have extension support.

sergiokopplin commented 3 years ago

@notSeaSmoke Agree! My idea it to have just an inspiration on colors to apply here, not to use the extension itself.

notSeaSmoke commented 3 years ago

Oh yeah, that makes more sense. Personally, I find the Dark Reader theme a bit too dark. I prefer a color scheme like GitHub's new Dark Dimmed theme, it's dark enough to not cause eye strain while also being light enough to not cause reading issues like pure black themes. The dynamic theme engine in Dark Reader with default settings is the closest to what I'd personally like.

sergiokopplin commented 2 years ago

What do you guys think about? https://github.com/sergiokopplin/indigo/pull/484

sergiokopplin commented 2 years ago

@heychirag @Nazeeefa @notSeaSmoke I've made a proposal.

sergiokopplin commented 2 years ago

I'll merge, 🐛 are expected hahaha

sergiokopplin commented 2 years ago

demo: https://koppl.in/

Nazeeefa commented 2 years ago

Thanks. Dark theme looks nice, what sort of bugs should we expect? I guess, it's not possible to have dark/bright mode button?

sergiokopplin commented 2 years ago

@Nazeeefa yeah, it's possible, but it will add some javascript. We don't have any js Do you know any other ways of doing @Nazeeefa ?

vidhatha commented 2 years ago

@sergiokopplin any plans to add the button using js?