search

sergiomrebelo / evo-poster

The Evolutionary Poster Composer (evo-poster) is a generative poster design system. From a given content (including text and imagery), evo-poster can generate and evolve poster designs considerating the aesthetic and semantics features of the content.
MIT License
3 stars 0 forks source link

Lexicon-based not recursive analysis by line #2

Closed sergiomrebelo closed 1 year ago

sergiomrebelo commented 1 year ago

To find an alternative when it is necessary to conduct a line-by-line emotion analysis. I found a bug in the other version and currently its works in a recursive way (bad performance and slower in long texts).

sergiomrebelo commented 1 year ago

✅ Lexicon global analysis is performed independently. (See nlp_utils/test.js).

JJ commented 1 year ago

You can refer to specific issues in the commit message simply by inserting the number of the issue. It will help check what was actually done here.

sergiomrebelo commented 1 year ago

I did not know. I'm still a little noob on GitHub. Today, I took some time read about conventional naming for commits. From now on I'll use Angular Commit Message Format, including the issue in the end of header

JJ commented 1 year ago

That is fine, but a minimalist approach to that is also OK. It's important that the first line only has 50 characters, so that it's not split by the GitHub interface (also, that's the convention for git log and all that), and that it includes the issue you're working with (so that it's easy to click and understand the context of the code that's been created). The rest is OK, but probably unnecessary