search

sergiomrebelo / evo-poster

The Evolutionary Poster Composer (evo-poster) is a generative poster design system. From a given content (including text and imagery), evo-poster can generate and evolve poster designs considerating the aesthetic and semantics features of the content.
MIT License
3 stars 0 forks source link

Refactor `evolutionInterface` component #34

Closed sergiomrebelo closed 1 year ago

sergiomrebelo commented 1 year ago

The evolutionInterface.js component appears to be overly extensive and contains repetitive code. It would be beneficial to divide it into smaller, more manageable components.

JJ commented 1 year ago

Remember that if there's not a user story after that, it's complicated to check whether there is an actual improvement. There are measures for that, like cyclomatic complexity, but also test coverage. I guess you know the concept, but basically more manageable means that it's easier to test... Which implies that you can check whether whatever you do for this is working as long as it improves coverage.

sergiomrebelo commented 1 year ago

This interface is completely functional and it is designed based on the users' stories (see issue #22). However, the current code is quite confusing and a bit repetitive. It needs to be divided into small components in order to make it easy to understand and further update. Tomorrow, we talk a little bit more about it.

sergiomrebelo commented 1 year ago

I subdivided the interface, creating a set of new components to each input and main componentes for each panel.

sergiomrebelo commented 1 year ago

Currently the code is more easy to read and update.