sergiop / react-giphy-searchbox

Responsive and customizable search and select for Giphy's GIFs and Stickers.
https://sergiop.github.io/react-giphy-searchbox/
MIT License
48 stars 19 forks source link

Add management for image rendition. #39

Closed sergiop closed 3 years ago

sergiop commented 4 years ago

Closes https://github.com/sergiop/react-giphy-searchbox/issues/37

Accordingly official docs i added two new props:

Note: I have no time at the moment to add the support for the mp4 filetype since it needs a proper player.

@caleb15 let me know what you think and it would be great if you can test this feature a little, I didn't have so much time to do it.

codecov[bot] commented 3 years ago

Codecov Report

Merging #39 (ada66ff) into master (aef0cc2) will decrease coverage by 0.90%. The diff coverage is 75.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
- Coverage   99.01%   98.11%   -0.91%     
==========================================
  Files          13       13              
  Lines         102      106       +4     
==========================================
+ Hits          101      104       +3     
- Misses          1        2       +1     
Impacted Files Coverage Δ
src/index.js 95.00% <ø> (ø)
src/components/ImageItem/ImageItem.js 85.71% <75.00%> (-14.29%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update aef0cc2...ada66ff. Read the comment docs.