NullPointers :) - Githubissues

sergiosorias / jscep

Automatically exported from code.google.com/p/jscep

MIT License

0 stars 0 forks source link

NullPointers :) #52

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago

Hi, you could avoid some null pointers by making the equals comparison on 
constants :) 

In Example use if (!"text/plain".equals(mimeType)) instead of       if 
(mimeType.equals("text/plain") == false)

I was using jscep as a client and the server did not return anything for 
getCACaps that's how i found it but after searching a bit i found more of them.

Have a nice day !

Original issue reported on code.google.com by StanciuT...@gmail.com on 18 Aug 2011 at 3:57

Merged into: #56

GoogleCodeExporter commented 9 years ago

Original comment by da...@grant.org.uk on 23 Aug 2011 at 8:08

Added labels: Milestone-1.3, Priority-Medium, Type-Defect

GoogleCodeExporter commented 9 years ago

Thanks for this.  Could you create a patch against trunk please?

Original comment by da...@grant.org.uk on 23 Aug 2011 at 8:13

Changed state: Accepted

GoogleCodeExporter commented 9 years ago

Original comment by da...@grant.org.uk on 23 Aug 2011 at 8:14

Added labels: Component-API

GoogleCodeExporter commented 9 years ago

Original comment by da...@grant.org.uk on 19 Jan 2012 at 7:11

Changed state: Duplicate

GoogleCodeExporter commented 9 years ago

Original comment by da...@grant.org.uk on 21 Aug 2012 at 12:26

Removed labels: Milestone-1.3