search

sergiusens / darktable-snap

Darktable snap recipe.
GNU General Public License v3.0
10 stars 6 forks source link

Update to 3.0.0 #25

Closed kevinmehall closed 4 years ago

kevinmehall commented 4 years ago

This is based on #22, but fixes the lensfun data path and a library dependency warning emitted by snapcraft.

kyrofa commented 4 years ago

Thanks for this @kevinmehall. I've tested and merged #22, mind rebasing this?

kevinmehall commented 4 years ago

Rebased

kyrofa commented 4 years ago

@kevinmehall rather than organize, I've pushed an update that uses /usr as the prefix thereby installing everything into the same places as the stage-packages, which seems a little more elegant. Can you give this a test for me and confirm that it works as expected?

kyrofa commented 4 years ago

I've given this some good testing and am fairly confident it works properly. Let's get this out there.

kevinmehall commented 4 years ago

Yep, looks good, thanks.

The test for this is just that the list of cameras and lenses shows up in the "lens correction" module, and it's working fine in the 3.0.0 release from the snap store.

I tried using DCMAKE_INSTALL_PREFIX initially, but must have been doing something wrong (I think I was using the path in the snap build dir instead of just /usr).