search

sergix44 / XBackBone

A lightweight file manager with full ShareX support and more
https://xbackbone.app
GNU Affero General Public License v3.0
993 stars 81 forks source link

Support For Vanity Urls #507

Closed SrS2225a closed 1 year ago

SrS2225a commented 1 year ago

Allows you (the user) to rename the random ID that uploads are assigned and give them a special vanity/custom url! As example: If XBackBone generated a link such as https://media.nyxgoddess.org/talI2/DIsexobi55.mp4, but want something a little more custom, you can easily change that link to https://media.nyxgoddess.org/talI2/amongus.mp4.

Additionally, if you try to change the generated link to a invalid url such as "https://media.nyxgoddess.org/talI2/among us.mp4" XBackBone will automatically add a - to make it valid. Like so: https://media.nyxgoddess.org/talI2/among-us.mp4

SrS2225a commented 1 year ago

Oh no, I see. Should I worry about these failed tests and clean up those code quality issues before you merge it? Or will the current changes be sufficient enough?

sergix44 commented 1 year ago

Oh no, I see. Should I worry about these failed tests and clean up those code quality issues before you merge it? Or will the current changes be sufficient enough?

Yes please try to make the CI pass, at least the stuff related to code style 🙏

SrS2225a commented 1 year ago

Hi, I have fixed those styling issues and the CI was able to pass as normal. Do you need anything else?

sergix44 commented 1 year ago

Hi, I have fixed those styling issues and the CI was able to pass as normal. Do you need anything else?

Thanks! I'll review the PR asap

SrS2225a commented 1 year ago

Hi,

It's been a while since I heard anything from this PR so I wanted to see if you were able to review it and everything was alright. Please let me know if you have any questions or want anything changed before you accept it

SrS2225a commented 1 year ago

Thanks, glad you like the PR! Sorry about the issues tho. I will start working on solving all of the requested fixes. I will add a comment when it is complete, or when I have any other further comments starting out from the easiest one to fix to the requested changes. Once all of them are fixed I will add a separate comment letting you know

SrS2225a commented 1 year ago

Hi,

I have fixed all of the issues as you requested and pushed the changes to my fork. We should all be good to go. Please let me know if I missed anything. I also added comments in reply to your feedback on my thoughts.

SrS2225a commented 1 year ago

Hello,

I wanted to see how the review was going as I have not heard anything from you for this merge request in a while. Is everything alright? I want to make sure everything was good with you and have not missed anything so this feature becomes official!

xbdmHQ commented 1 year ago

@SergiX44 Please respond, I know you got real life stuff you got going on.

sergix44 commented 1 year ago

I'll check this out soon, sorry for the late reply, the notification was lost in the ddos that I receive every day

DinnerBeef commented 1 year ago

@SrS2225a any idea when you will get a chance to look at this? Been hoping this gets merged in for a while.

SrS2225a commented 1 year ago

Ill be taking a look now. Been too busy with personal matters over the last month, so I have not been table to take a look for a while