sergix44 / XBackBone

A lightweight file manager with full ShareX support and more
https://xbackbone.app
GNU Affero General Public License v3.0
993 stars 81 forks source link

[UploadController] Response now includes a `raw_url` field #533

Closed cursey closed 1 year ago

cursey commented 1 year ago

I have sharex configured to add /raw to the end of every uploaded file automatically but that results in broken .gif thumbnails in discord and requires extra configuration steps.

This change just includes a properly formatted raw_url field in the /upload response that can be used more easily from sharex and creates working gif thumbnails in discord.

Note: The broken gif thumbnails in discord seems to be entirely discords fault. I think they're just looking at the URL and seeing if it ends in .gif which is why this change fixes that behavior.

angelfor3v3r commented 1 year ago

I tested this out on an instance I'm running and it does indeed fix my issue at #493. The only thing I had to do is change my ShareX config to read the raw_url instead. It seems like certain sites/apps specifically look for extensions + a raw site (i.e. without the XBackBone interface). The "copy raw url" mode exists which does exactly this, I guess it only makes sense to have it available in the API too? Perhaps down the line an option in the user settings page to generate the ShareX config with this in already set would be nice, too.

Closes #493