Unbreak LibreSSL implementation testing

sergot / openssl

OpenSSL bindings for Perl 6

MIT License

14 stars 31 forks source link

Unbreak LibreSSL implementation testing #78

Closed Altai-man closed 4 years ago

Altai-man commented 4 years ago

Do not check OpenSSL specific attribute and properly document it, which allows testing on platform where LibreSSL is used pass. Fixes https://github.com/sergot/openssl/issues/63 Fixes https://github.com/sergot/openssl/issues/53

Altai-man commented 4 years ago

Can anyone test that on:

[x] Ubuntu with openssl
[ ] Macos
[ ] Windows

Cloning of this branch and doing zef test . is enough.

rbt commented 4 years ago

Ubuntu 19.10 passes.

libressl-fixes rbt@rbt-inspiron-123:~/work/openssl$ git branch
* libressl-fixes
  master

libressl-fixes rbt@rbt-inspiron-123:~/work/openssl$ apt list --installed openssl*
Listing... Done
openssl/eoan,now 1.1.1c-1ubuntu4 amd64 [installed,automatic]

libressl-fixes rbt@rbt-inspiron-123:~/work/openssl$ NETWORK_TESTING=YES zef test .
===> Testing: OpenSSL:ver<0.1.23>:auth<github:sergot>
===> Testing [OK] for OpenSSL:ver<0.1.23>:auth<github:sergot>

ugexe commented 4 years ago

@Altai-man can you force push so this can rebuild on AppVeyor?

Altai-man commented 4 years ago

@ugexe this won't really help. It builds rakudo HEAD, which is currently broken with a segfault on windows, see https://github.com/rakudo/rakudo/issues/3568 That's why I was asking people who already have e.g. a stable rakudo image on their machines to test that out and then it got stuck. Honestly, I think this can be just merged right away, because it doesn't change a thing in the implementation, simply removing a bogus test, but a bit of politeness hardly hurts for something which was broken for years on libressl.