search

sergot / openssl

OpenSSL bindings for Perl 6
MIT License
14 stars 31 forks source link

Revert "Revert "Use JSON::Fast to handle json" (#88)" #96

Closed usev6 closed 2 years ago

usev6 commented 2 years ago

This reverts commit 20e89d2e55e4023e0a31dafd7d4bbf2cbfb36a95.

I believe that @patrickbkr and @niner found the real fix for the spurious failures in OpenSSL::RSAKey with b37d5a0c8b. So the revert, which only served as a bandaid, is no longer needed.

usev6 commented 2 years ago

I've restored the environment I used for testing in https://github.com/sergot/openssl/issues/87 and swapped out the revert with the fix from https://github.com/sergot/openssl/pull/95.

$ raku --version
Welcome to Rakudo(tm) v2021.05.
Implementing the Raku(tm) programming language v6.d.
Built on MoarVM version 2021.05.
$ zef --version
v0.11.7
$ cat /etc/debian_version  ## a bit newer than last year
10.11

Again I've run the commands that triggered the error multiple times and didn't see a single error. (To be sure I also tried with the version 0.1.25 (so neither the bandaid nor the new fix applied) and the error was still there.) So I'm pretty confident that the problem is finally gone.