serhack / pdf-diff

A tool for visualizing differences between two pdf files.
MIT License
819 stars 41 forks source link

No image generated #9

Closed SergioB-dev closed 2 years ago

SergioB-dev commented 2 years ago

Hi! Very cool project.

I'm having some problems, I'm hoping you can offer some guidance in case I am doing something wrong.

Expected Output

The images generated by pdf are inserted into a folder named as the hash of the content of the pdf file. E.g. the file has the hash fc324.., the images are in the fc324 folder. If a folder with that name already exists, pdf-diff will not create any images since it consider that images were already generated. Once ran, the images are created in the folder generated.

Actual Output

I got two separate folders with different shas generated, but with no content. Also the generated folder remains empty.

What am I doing wrong?

serhack commented 2 years ago

Hi, thanks for creating a new issue. Have you installed poppler-utils? Try to open a new shell and type pdftoppm. If there's "no command found" error, probably you need to install it.

For sure I have to find a way to report the lack of pdftoppm as an error.

SergioB-dev commented 2 years ago

Thanks for the quick reply. You're right. I needed to have that package. I assumed that it came default with brew but it does not. I opened a PR that adds the relevant Mac command to the README.

serhack commented 2 years ago

Thank you for the PR. Closing the issue.