serhatbolsu / robotframework-appiumlibrary

AppiumLibrary is an appium testing library for RobotFramework

Apache License 2.0

403 stars 291 forks source link

Add support for frames #322

Open technigirl opened 3 years ago

technigirl commented 3 years ago

I would like to suggest adding support for Appium commands Switch to Frame and Switch to Parent Frame.

Details here: http://appium.io/docs/en/commands/web/frame/switch/ http://appium.io/docs/en/commands/web/frame/parent/

serhatbolsu commented 3 years ago

I will welcome an PR

serhatbolsu commented 3 years ago

319

technigirl commented 3 years ago

there is one approved already but never merged... https://github.com/serhatbolsu/robotframework-appiumlibrary/pull/184

does it need revision?

studioromeo commented 3 years ago

Hey @serhatbolsu

Appreciate everything you've done here but would you mind taking a look at #184 and suggesting what changes you'd like being made? It seems like a reasonably popular PR that would benefit a lot of consumers of this library.

Thanks

joshuariveramnltech commented 1 year ago

@serhatbolsu this issue has been resolved by https://github.com/serhatbolsu/robotframework-appiumlibrary/pull/184 and can now be closed.