search

serhiisol / ngx-auth

Angular 16+ Authentication Module
MIT License
234 stars 47 forks source link

Angular 8 compatibility #48

Closed ymanvieu closed 5 years ago

ymanvieu commented 5 years ago

hello,

I just upgrade to Angular 8.0.0 and having the following warnings:

warning " > ngx-auth@5.0.0" has incorrect peer dependency "@angular/core@^7.0.0".
warning " > ngx-auth@5.0.0" has incorrect peer dependency "@angular/compiler@^7.0.0".
warning " > ngx-auth@5.0.0" has incorrect peer dependency "@angular/router@^7.0.0".
warning " > ngx-auth@5.0.0" has incorrect peer dependency "@angular/common@^7.0.0".

ngx-auth seems to work anyway but can you take a look ?

thanks

serhiisol commented 5 years ago

Thanks for the issue, I'll push changes asap.

sonusindhu commented 5 years ago

Is there any updates on this issue @serhiisol ?

serhiisol commented 5 years ago

@sonusindhu sorry for delay, got laptop broken so I had to return it to the service shop to fix it

serhiisol commented 5 years ago

Released.