search

serhiisol / ngx-auth

Angular 16+ Authentication Module
MIT License
234 stars 47 forks source link

verifyRefreshToken receiving wrong parameter #54

Closed alexjavier15 closed 4 years ago

alexjavier15 commented 4 years ago

The method verifyRefreshToken in AuthService is expecting an object of type HttpRequest

https://github.com/serhiisol/ngx-auth/blob/ee237f26622ea9aa5612c350c6f7a30ded4be1b7/src/auth.service.ts#L41

However, the interceptor is passing the request url sting https://github.com/serhiisol/ngx-auth/blob/ee237f26622ea9aa5612c350c6f7a30ded4be1b7/src/auth.interceptor.ts#L169-L180

what ends up in the awful error

"Cannot read property 'endsWith' of undefined"

serhiisol commented 4 years ago

Hi @alexjavier15, good catch, I'll update library tonight.

serhiisol commented 4 years ago

Done :) it's published under 5.3.0

alexjavier15 commented 4 years ago

Thank you very much! I'll check it out right away

serhiisol commented 4 years ago

No problem, I hope it will help you. Cheers :D