feat: add current request to refreshShouldHappen - Githubissues

serhiisol / ngx-auth

Angular 16+ Authentication Module

MIT License

234 stars 47 forks source link

feat: add current request to refreshShouldHappen #58

Closed Maxlisui closed 3 years ago

Maxlisui commented 3 years ago

PR Type

[x] Feature
[ ] Chore
[ ] Bugfix
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Currently refreshShouldHappen ony receives the HttpResponseError, it would be convenient to also include the current request.

What is the new behavior?

refreshShouldHappen additionally receives HttpRequest.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

serhiisol commented 3 years ago

Yup, makes sense, thank you for the PR. I'm going to release new version asap.