search

seriallos / raidbots-issues

Issues found on raidbots.com
3 stars 1 forks source link

Crafted Items don't sim the correct stats #311

Closed NinaMizuki closed 3 years ago

NinaMizuki commented 3 years ago

The Bug

Crafted Items like the Shadowlace gear etc have the options to either be crafted with two different stats, or two of the same stat, causing it to have double the normal amount of that one stat. Raidbots will not accurately sim that and instead only sim it as if only one instance of the stat existed, resulting in a very low sim.

To Reproduce

Steps to reproduce the behavior:

  1. Go to Gear Compare
  2. Choose any of the Crafted Items
  3. Select either one of the singular stats "Haste", "Mastery", "Versatility", "Crit"
  4. Sim it, then proceed to check the results.

Expected behavior

It would sim the item as if crafted with two missives of the same stats (+81 1 Stat instead of +41 1 Stat).

Link a sim with the problem (if available)

https://www.raidbots.com/simbot/report/5VzjiXLVCRfQP9j84GXirG

seriallos commented 3 years ago

Crafted items always have two different secondary stats. The way in which they differ is how many optional reagents can be used to determine those stats (the JC items have a fixed stat and then one that can be controlled).

The options in Gear Compare can be used to create an item that can't actually exist in game - the Shadowlace gear with 1 stat in those sims can't be created. The single stat options are meant to be used with the JC items that only have 1 slot for an optional reagent. The double stat options are meant for the non-JC pieces that have two optional reagents.

Gear Compare is generally a more flexible tool that will sometimes let you test items that can't actually be obtained in-game so you do have to be a bit careful when using it.