seriallos / raidbots-issues

Issues found on raidbots.com
3 stars 1 forks source link

Existing prismatic sockets stay empty if additional sockets are added #379

Closed cremor closed 1 year ago

cremor commented 1 year ago

Describe the bug Sometimes Top Gear sims leave existing/default prismatic sockets empty when another prismatic socket is added to the item.

To Reproduce Steps to reproduce the behavior:

  1. Run a Top Gear sim that has an item with an empty prismatic socket in the bag and also enable the option to add additional prismatic sockets.
  2. Check the results.
  3. Notice that some (but not all) results leave the existing prismatic socket empty.

Expected behavior All prismatic sockets should be filled with gems.

Link a sim with the problem (if available) https://www.raidbots.com/simbot/report/1DWi83rdFuqEdkRPKjCQLH

Character or /simc input Note: I've manually added the neck item with the empty prismatic slot to the bags section. The line itself is copied from a Droptimizer professions run.

# Cremor - Retribution - 2022-12-28 18:57 - EU/Blackmoore
# SimC Addon 10.0.2-04
# WoW 10.0.2.47213, TOC 100002
# Requires SimulationCraft 1000-01 or newer

paladin="Cremor"
level=70
race=human
region=eu
server=blackmoore
role=attack
professions=blacksmithing=66/mining=100
spec=retribution

talents=BYEAwtJ2KpR8WbGzhz/jy2AP8AAAAAAACgIKplkIBkkkWKJJRJAAAAAAACRSSaJBJINJJJloEA

# Saved Loadout: Solo
# talents=BYEAwtJ2KpR8WbGzhz/jy2AP8AAAAAAgIBgolSSCJBJkSKJJpUCAAAAAAg0QSSkEiElUSSQJKB
# Saved Loadout: Single Target
# talents=BYEAwtJ2KpR8WbGzhz/jy2AP8AAAAAAACgIKplkIBkkkWKJJRJAAAAAAACRSSaJBJINJJJloEA
# Saved Loadout: Cleave
# talents=BYEAwtJ2KpR8WbGzhz/jy2AP8AAAAAAgIBgkWaJJEQSSKpkkElAAAAAAAIEJJplEkQJtkEUiSA
# Saved Loadout: M+
# talents=BYEAwtJ2KpR8WbGzhz/jy2AP8AAAAAAIiEASaplkQAJJpkSSSUCAAAAAAg0EJJpJQSUSJJBlQA
# Saved Loadout: Sennarth
# talents=BYEAwtJ2KpR8WbGzhz/jy2AP8AAAAAAgIBIiSaJJEQSSapkkElAAAAAAAIEJJplEkQJFRSUiSA
# Saved Loadout: Dathea
# talents=BYEAwtJ2KpR8WbGzhz/jy2AP8AAAAAAgIBIiSaJJEQSSapkkElAAAAAAAIEJJplEkQJtkEUiSA
# Saved Loadout: M+ Aura
# talents=BYEAwtJ2KpR8WbGzhz/jy2AP8AAAAAAIiEASaplkQAJJpkSSSUCAAAAAAg0SkkkmAJRJlDkEUCB

head=,id=200757,bonus_id=40/7936/1585/5864/8767
neck=,id=200762,bonus_id=6652/7936/8783/1478/8767
shoulder=,id=200419,bonus_id=7979/6652/8826/1472/8767
back=,id=200971,enchant_id=6597
chest=,id=200414,enchant_id=6624,bonus_id=7979/6652/8830/1469/8767
shirt=,id=98543
tabard=,id=46874
wrist=,id=192012,enchant_id=6579,bonus_id=6652/7936/1485/5864/8767
hands=,id=198737,bonus_id=1472
waist=,id=195524,bonus_id=7979/6652/7936/8821/8818/1472/8767
legs=,id=192009,enchant_id=6492,bonus_id=6652/1481/5865/8767
feet=,id=200457,enchant_id=6605,bonus_id=1472
finger1=,id=200159,enchant_id=6555,bonus_id=6652/7936/1491/5865/8767
finger2=,id=193696,enchant_id=6555,bonus_id=8965/7977/6652/7936/9144/1611/8767
trinket1=,id=194308,bonus_id=7979/6652/1472/8767
trinket2=,id=193679,bonus_id=8969/7977/6652/9144/1624/8767
main_hand=,id=190510,enchant_id=6638,bonus_id=8836/8840/8902/8800/8793/8796/8960,crafted_stats=49/32

### Gear from Bags
#
# Nats Hut (5)
# head=,id=88710
#
# Schulterstücke der geschmolzenen Macht (402)
# shoulder=,id=195477,bonus_id=7980/43/8825/8817/1485/8767
#
# Wickeltuch der Einheit (20)
# back=,id=63206
#
# Umhang der Koordination (29)
# back=,id=65360
#
# Tuch der Zusammenarbeit (20)
# back=,id=63352
#
# Brustplatte der erwiesenen Wissens (392)
# chest=,id=193705,bonus_id=8966/7977/6652/8822/8820/9144/1614/8767
#
# Nat Pagles Extremanglerstiefel (22)
# feet=,id=19969
#
# Lebensflammenampulle (379)
# trinket1=,id=198451,bonus_id=6652/1433/5865/8767
#
# Azurarkanverstärker (379)
# trinket1=,id=198407,bonus_id=6652/1433/5865/8767
#
# Grals abgelegter Zahn (376)
# trinket1=,id=192797,bonus_id=6652/1481/5862/8767
#
# Irideusfragment (372)
# trinket1=,id=193743,bonus_id=7977/6652/1594/8767
#
# Rubinwelpenpanzer (392)
# trinket1=,id=193757,bonus_id=8966/7977/6652/9144/1614/8767
#
# Atem der Ebenen (376)
# trinket1=,id=198539,bonus_id=6652/1430/5865/8767
#
# Urzeitliche Ritualmuschel (372)
# trinket1=,id=200563,bonus_id=41/1475/5864/8767
#
# Unlöschbarer Hammer (369)
# main_hand=,id=200247,bonus_id=6652/1475/5861/8766
#
# Hochgewürgte Steinhandaxt (382)
# main_hand=,id=200167,bonus_id=6652/1488/5861/8767
#
# Drachenschuppenlangschild (366)
# off_hand=,id=192016,bonus_id=6652/1468/5865/8766
# neck=,id=193001,bonus_id=8960/8840/8836/8902/8783/8784/8780/1495,crafted_stats=36/49

# Checksum: 370ae254
seriallos commented 1 year ago

Rolling out a change that should fix this right now, should work as expected in 20-30 minutes.