serialport / bindings-cpp

The C++ bindings for the node serialport project.
MIT License
20 stars 40 forks source link

Wont build on python 2 #1

Closed reconbot closed 2 years ago

reconbot commented 2 years ago

Half of the prebuildify-cross images use python 2 https://github.com/prebuild/docker-images/issues/15 so we can't build on them. I'm not sure why however.

thegecko commented 2 years ago

Linked PR fixes this issue, but if you want to use different cross-build images (e.g. with python3 installed), you'll need to roll your own containers.

See here for example:

https://github.com/node-usb/docker-images

reconbot commented 2 years ago

I like the node-usb docker images, any reason we couldn't use those?

thegecko commented 2 years ago

I like the node-usb docker images, any reason we couldn't use those?

They won't contain python3 :)

They were needed to add the libudev-dev compilation dependency