search

serialport / bindings-cpp

The C++ bindings for the node serialport project.
MIT License
22 stars 43 forks source link

Fix unsupported architecture for MacOS #100

Closed GlaceCoding closed 1 month ago

GlaceCoding commented 1 year ago

Hi,

With OTHER_ prefix my macos is not able to build the module with node-gyp. With this fix it is able to build. :)

fix: #99

papakpmartin commented 1 year ago

Thanks for this, @GlaceCoding! It would be nice to get this merged.

GlaceCoding commented 1 year ago

@reconbot ☝🏻

(I don't know if you watch this repository, I allow myself to ping you.)

reconbot commented 1 year ago

I was asking my self it is really 'OTHER_CFLAGS' that you want to do ?

It looks like you're on an older os and xcode? none of my machines or CI have issues with the "other" flags. We've had it setup this way for over 10 years. However, it seems to build fine with this change, it needs some testing. I'd feel more comfortable if I knew the impact of the change but I can't find documentation. It is the way it is because it got that way.

GlaceCoding commented 1 year ago

I tried on a Mojave but I thought my teammate had last macbook air version (because they need to do it also) 🤔

reconbot commented 1 month ago

This doesn't seem to be an issue for most OSs