search

serialport / bindings-cpp

The C++ bindings for the node serialport project.
MIT License
22 stars 42 forks source link

Install setuptools on macos workflows #168

Closed thegecko closed 1 month ago

thegecko commented 9 months ago

Macos workflows are currently broken because the hosts no longer have some key tools for some reason.

This PR fixes the build and test macos flows

thegecko commented 9 months ago

Anything needed to chaperone this through?

boneskull commented 8 months ago

I just ran into this. distutils was removed in Python v3.12

thegecko commented 8 months ago

@reconbot can we expedite this?

thegecko commented 7 months ago

bump

Julusian commented 5 months ago

In one place 'macos-11' is used, in another 'macos-latest'. Does this mean it will break when updating/changing the macos image? Perhaps the check should be done as runner.os == 'macOS' so that it doesn't care what image is used?

thegecko commented 4 months ago

In one place 'macos-11' is used, in another 'macos-latest'.

Yeah, I don't know why this is. I'll try to converge on one and see if it still builds....

Julusian commented 4 months ago

In one place 'macos-11' is used, in another 'macos-latest'.

Yeah, I don't know why this is. I'll try to converge on one and see if it still builds....

Part of why I asked this is because the macos-11 image is deprecated and being phased out https://docs.github.com/en/actions/using-github-hosted-runners/about-github-hosted-runners/about-github-hosted-runners#standard-github-hosted-runners-for-public-repositories so that will need changing to macos-12 or something soon, which will also need updating on this check

reconbot commented 1 month ago

I've updated everything to macos-latest which is os14 today. If something like this happens again we can open an issue on the runner images repo and they'll fix it.