search

serialport / bindings-cpp

The C++ bindings for the node serialport project.
MIT License
19 stars 39 forks source link

Update Node dependency from 12.17.0 to 12.14.1 #61

Closed jakobrosenberg closed 2 years ago

jakobrosenberg commented 2 years ago

Is it possible to change the Node dependency from 12.17.0 to 12.14.1?

Currently we can't get the bindings to work in Atom because Atom bundles with 12.14.1. We can get it working by running npm install manually in the package folder, but that's not something we can ask our users to do.

reconbot commented 2 years ago

As long as that version supports the napi we’re targeting there’s no problem with it. But I think that is why we chose this version.

reconbot commented 2 years ago

As an aside, mind if I ask the use case for atom? Like what the product is?

jakobrosenberg commented 2 years ago

Sure. https://github.com/pycom/pymakr-atom and https://github.com/pycom/pymakr-vsc.

I didn't write either library, but I have the good fortune of maintaining them.

I'm currently working on a new version for VSCode, written completely from scratch. As far as I know, it doesn't have any issues with serialport. https://github.com/pycom/pymakr-vsc/tree/next

reconbot commented 2 years ago

Unfortunately we need to target n-api v6, and 12.17.0 is the lowest supporting node v12 for n-api v6

https://nodejs.org/api/n-api.html#node-api-version-matrix

jakobrosenberg commented 2 years ago

Thanks for the clarification, @reconbot . For whatever reason it's working on both Windows and WSL but not Mac/Linux.

Do you have a recommendation for how to best approach this?

reconbot commented 2 years ago

I don't know a thing about atom. Chances are they don't support the newer napi but do support it enough to not crash most of the time when you force the install.

reconbot commented 2 years ago

Sorry I couldn't help further.

jakobrosenberg commented 2 years ago

Appreciate the effort and the great library. ❤️