search

serialport / bindings-cpp

The C++ bindings for the node serialport project.
MIT License
21 stars 40 forks source link

allow to set rts/dtr/brk/cts/dsr seperately for windows #76

Open gengshenghong opened 2 years ago

gengshenghong commented 2 years ago

This PR allows to set rts/dtr/brk/cts/dsr seperately for windows. It will always set a true/false value for these signals when using set function, which will triggle multiple EscapeCommFunction on windows. It will cause issues in some corner cases. For exmaple, in the esp32 flash logic, it needs to use rts and cts to control the IO signals, when using this library, the extra EscapeCommFunction will make the signal a little longer and it will fail to enter download mode. I've fixed it if we can set them seperately, please review the details in this PR. Thanks.

reconbot commented 1 year ago

I think we always pass true/false values into this function from serialport itself, this change will have to make its way through the stack