search

seriema / angular-apimock

Automatically route your API calls to static JSON files, for hiccup free front–end development.
johansson.jp/angular-apimock
MIT License
65 stars 8 forks source link

feat(apiPath): add support for arrays and/or regexp when matching #29

Closed Wolfium closed 9 years ago

Wolfium commented 9 years ago

It include tests for added feature

Fix #16

seriema commented 9 years ago

The build-failure seems be because of SauceLabs credentials not working. It got fixed now in #36 so you can update your fork (see instructions). Then try a git push --force to get Github to retrigger the builds and tests.

Btw, a tip for future PR's is to create a new branch on your fork so it's easier for you to keep things updated.

seriema commented 9 years ago

It's so awesome of you to help! It would be great if you could add documentation to the readme on how to use the feature.

Wolfium commented 9 years ago

Almost done, just need to add documentation on readme and separate test case each as you stated, will let you know when finished tomorrow to be reviewed and merged

Wolfium commented 9 years ago

All improvements done.

I reverted the dist files update buy not sure how to rewrite git history to remove the wrong commit.

seriema commented 9 years ago

Thanks @Wolfium ! There's a nice answer on StackOverflow that you can follow to squash this into one commit. Check the "Optional - Cleaning commit history" section of the answer. You shouldn't need the git remote add parent part though, as my remote should already be in your list as you did a PR. Type git remote and see if there's something other than "origin". I'd guess you have "origin" and "seriema". In the last step you'll be force pushing it to Github with git push -f, but you can test it out with git push -f --dry-run first to make sure nothing's going to break mid way.

I'm available on Gitter if you want to chat with me while you try it.

seriema commented 9 years ago

Great work so far @Wolfium ! If you could squash your commit I'd be happy to merge it =)

Wolfium commented 9 years ago

I didn't forget but not to much time for the squash, will back to this as soon as possible.

Wolfium commented 9 years ago

Hi @seriema, it took me a while to get a single commit, but I learn a lot about git. :+1:

I hope now it is OK to be merged, I would like to use the new version from official repo. Let me know.

Regards

seriema commented 9 years ago

Wow! Great work @Wolfium !!! Thank you so much for your patience!! =D Yeah, I learned this lesson the hard way when I did the Grunt PR for Twitter Bootstrap. Took me 3 months and then in less than a day they go from asking me to squash, to squashing a copy themselves and close my PR :laughing:

seriema commented 9 years ago

@Wolfium feel free to take a look at #24 or comment on it with some ideas of how you'd like to use it. I'd like to include it before releasing a new version but I won't have much this week because a friend is visiting and it's been planned for months.

Wolfium commented 9 years ago

Just from the starting comment about multiple routes this would be related to #28

seriema commented 9 years ago

Yepp, I noted that at the bottom of 28 and you can see the reference comment autogenerated by github.

Wolfium commented 9 years ago

:+1:

seriema commented 9 years ago

0.3.0 is out! Thanks @Wolfium :+1:

Wolfium commented 9 years ago

Great, today will update to new version...!!! Thanks to you

On Mon, Oct 5, 2015 at 4:33 PM John-Philip Johansson < notifications@github.com> wrote:

0.3.0 is out! Thanks @Wolfium https://github.com/Wolfium [image: :+1:]

— Reply to this email directly or view it on GitHub https://github.com/seriema/angular-apimock/pull/29#issuecomment-145643945 .

Saludos. Nestor