search

seriema / angular-apimock

Automatically route your API calls to static JSON files, for hiccup free front–end development.
johansson.jp/angular-apimock
MIT License
65 stars 8 forks source link

Decide on a date format for URL query params #50

Open seriema opened 9 years ago

seriema commented 9 years ago

While working on #44 I added a test case for dates, and the expected file name becomes so long. 1996-01-27 becomes the ISO string 1996-02-27t00:00:00.000z. E.g. a potential file name would be /mock_data/pokemon/releasedate=1996-02-27t00:00:00.000z.get.json.

Question 1: How short is ok? YYYY-MM-DD or YY-MM-DD? With or without time of day? How short timestamp? HH-MM-SS is enough? Question 2: Should it be easy to override somehow? I'm thinking about scenarios in search API's or similar where the dates can change and would require multiple .json files to match. Maybe the date doesn't have a real impact on the UI design, like just outputting the date. But I can also think of scenarios where it does matter, like changing texts or colors depending on the date value.

MartinSandstrom commented 9 years ago

Question 1: I think YYYY-MM-DD and that HH-MM-SS is enough.

seriema commented 9 years ago

How would you imagine the final path? /mock_data/pokemon/releasedate=1996-02-27_00.00.00.get.json?

I just realised that the : in the timestamp that's currently created by v0.3.1 isn't a valid filename. Logged as #57