search

seriema / electron-notification-shim

Get Notification API events in Electron main-process. Perfect for adding Notification toasters in Windows with node-notifier or other solution.
MIT License
37 stars 5 forks source link

Custom event name #6

Open giuseppeg opened 7 years ago

giuseppeg commented 7 years ago

hey man thanks for this module! Would you accept a PR that enables custom event name to be passed to the shim?

seriema commented 7 years ago

@giuseppeg thanks!

What would it be used for? I'm trying to stick with the simple definition of a shim:

a shim is a small library that transparently intercepts API calls and changes the arguments passed, handles the operation itself, or redirects the operation elsewhere.

So it shouldn't be doing anything that the native Notification object doesn't do. My main goal is to simply enable desktop notifications on Windows when using Electron, since that isn't "built in".