serilog-archive / serilog-sinks-datadog

A Serilog sink that writes events to DataDog
Apache License 2.0
8 stars 8 forks source link

Updated to .NET core and latest Serilog. #9

Closed xivk closed 6 years ago

xivk commented 6 years ago

This should fix issues #8 #7

I didn't fix the buildscript because I'm awful at powershell. I'm hoping someone is willing to update that part?

merbla commented 6 years ago

@xivk try cherry picking this commit.

This is a quasi-standard build setup for sinks with .Net Core.

You should be able to iterate on that change to get the builds working.

xivk commented 6 years ago

That was quick, thanks! :+1:

Seems to be fixed (apart from my bad spelling in the commit message).

Perhaps the README should also be updated, it says .NET 4.5 now.

aregaz commented 6 years ago

When can we expect updated nuget package with dotnet core 2.0 support?

xivk commented 6 years ago

Ok, changed the project file to include VersionPrefix and updated the README.

That did remind me of the fact that the datadog dependency doesn't support 4.5 but it does support 4.5.1 so that's the minimum .NET framework version supported now.

xivk commented 6 years ago

Also, shouldn't we sync the package version with the assembly version?

nblumhardt commented 6 years ago

@xivk good point - since the package is no longer signed, we should probably just remove the assembly version and other information from the source and let the build system take care of it.

xivk commented 6 years ago

Or just use <Version>? Or is that not an option? It's unclear for me how the publishing to nuget works so it's up to you.

The CustomAssemblyVersion file is already removed.

nblumhardt commented 6 years ago

Thanks for the follow-up. <Version> won't work with the pre-release packaging scheme implemented in the build scripts. Hadn't noticed the custom assembly versioning removal - my bad, thanks!

xivk commented 6 years ago

OK, thanks :+1:

Anything left for me to do on this?

nblumhardt commented 6 years ago

Don't think so - thanks! :+1: