Closed xivk closed 6 years ago
@xivk try cherry picking this commit.
This is a quasi-standard build setup for sinks with .Net Core.
You should be able to iterate on that change to get the builds working.
That was quick, thanks! :+1:
Seems to be fixed (apart from my bad spelling in the commit message).
Perhaps the README should also be updated, it says .NET 4.5 now.
When can we expect updated nuget package with dotnet core 2.0 support?
Ok, changed the project file to include VersionPrefix and updated the README.
That did remind me of the fact that the datadog dependency doesn't support 4.5 but it does support 4.5.1 so that's the minimum .NET framework version supported now.
Also, shouldn't we sync the package version with the assembly version?
@xivk good point - since the package is no longer signed, we should probably just remove the assembly version and other information from the source and let the build system take care of it.
Or just use <Version>
? Or is that not an option? It's unclear for me how the publishing to nuget works so it's up to you.
The CustomAssemblyVersion file is already removed.
Thanks for the follow-up. <Version>
won't work with the pre-release packaging scheme implemented in the build scripts. Hadn't noticed the custom assembly versioning removal - my bad, thanks!
OK, thanks :+1:
Anything left for me to do on this?
Don't think so - thanks! :+1:
This should fix issues #8 #7
I didn't fix the buildscript because I'm awful at powershell. I'm hoping someone is willing to update that part?