search

serilog-archive / serilog-sinks-loggly

A Serilog event sink that writes to Loggly
Apache License 2.0
27 stars 30 forks source link

Durable sink retained file limit #13

Closed jblackburn21 closed 7 years ago

jblackburn21 commented 7 years ago

The RollingFileSink in the DurableLogglySink supports the ability to set the retained file limit, but the current implementation passes in null, so it would be unlimited. Would you accept a PR that would allow this to be overridden?

MiguelAlho commented 7 years ago

Sorry for the delayed response, but I don't believe I got a notification for this one. Yes, I can look into it if you send the PR, to help move that foward.

MiguelAlho commented 7 years ago

I'm working on a new item where i'll include this. I'll close this issue once it is completed

jblackburn21 commented 7 years ago

Great. Thanks! I haven't had a chance to get back to it yet.

MiguelAlho commented 7 years ago

This is now in 5.0.0. Use the retainedFileCountLimit argument to control this behaviour.