serilog-archive / serilog-sinks-loggly

A Serilog event sink that writes to Loggly

Apache License 2.0

27 stars 30 forks source link

Exception formatting #22

Closed tamirdresher closed 7 years ago

tamirdresher commented 7 years ago

This reduces the size of the exception details and remove noise

tamirdresher commented 7 years ago

This PR together with updating to version 4.6.1.43 of loggly-csharp solves issue#20

tamirdresher commented 7 years ago

20

tamirdresher commented 7 years ago

Fixed the issue you mentioned :-)

nblumhardt commented 7 years ago

👍 thanks Tamir.

camiller2 commented 7 years ago

@nblumhardt please forgive my ignorance, but any idea when this PR might be incorporated in a release? I'm on version 5.0.0 and am experiencing an issue where certain exceptions (DbEntityValidationException thrown from EF in particular) are successfully logged to Seq and Elmah but not Loggly. Thanks!

nblumhardt commented 7 years ago

@camiller2 just created #24 to push the release. Does the 5.1.0-dev package from NuGet fix the issue for you? It'd be great to validate that nothing's broken in the newest version. Cheers!

camiller2 commented 7 years ago

@nblumhardt it appears that 5.1.0-dev did indeed fix the issue :-) Thank you!

We haven't noticed any unexpected behavior, but we have only done very minimal testing locally; we're nervous to use a prerelease dependency in production.

nblumhardt commented 7 years ago

@camiller2 should be out once CI completes. Thanks for the feedback!

camiller2 commented 7 years ago

@nblumhardt perfect, thank you very much!