serilog-archive / serilog-sinks-loggly

A Serilog event sink that writes to Loggly
Apache License 2.0
27 stars 30 forks source link

migrated the obsolete xproj to the new csproj and updated nuget packages #23

Closed tamirdresher closed 7 years ago

tamirdresher commented 7 years ago

Migrated the obsolete xproj to the new csproj (https://docs.microsoft…com/en-us/dotnet/core/migration/).

Updated nuget packages ( #21 ):

nblumhardt commented 7 years ago

Great 👍

Issue with the build:

Collecting artifacts...
No artifacts found matching 'artifacts\Serilog.*.nupkg' path
Build success

The Serilog projects all generally use the same standardized Build.ps1 file - grabbing e.g. https://github.com/serilog/serilog-sinks-console/blob/dev/Build.ps1 and copying it in directly should fix this.

tamirdresher commented 7 years ago

@nblumhardt I reverted the Build.ps1 back to what it was. But i had to change the appveyor.yml in order to use the VS2017 image. Everything works the same as it was now.

nblumhardt commented 7 years ago

@tamirdresher awesome, merged!

I am going to bump the dev package version to 5.1 to reflect some change going on under the hood.

tamirdresher commented 7 years ago

Thanks @nblumhardt I'm happy that i could help. Looking forward to use the new package