search

serilog-archive / serilog-sinks-loggly

A Serilog event sink that writes to Loggly
Apache License 2.0
27 stars 30 forks source link

correct bookmark advance method, especially for situations where the … #46

Closed MiguelAlho closed 5 years ago

MiguelAlho commented 5 years ago

…read did not start on the first file in the set of buffer files on disk

as mentioned in https://github.com/serilog/serilog-sinks-loggly/issues/25 (reopened for this reason)

MiguelAlho commented 5 years ago

I performed a few tests using the sample app with the set of log files that reproduces the problem (from a production app) and changes a few params in the sample (removed files or moved the bookmark forward) and also tested with the retainedFileLimit param defined, and the erro behaviour seems to be gone.

nblumhardt commented 5 years ago

Hi Miguel! Unfortunately I'm struggling to find time to offer a proper review right now, but in any case, if this fixes known issues it seems like merging through to dev and getting some wider use would be worthwhile 👍 ... Cheers!

MiguelAlho commented 5 years ago

Thanks Nick, no problem. I'm going to get a couple of tests run with the prerelease package to be sure and I'll move it into dev. Initial tests seem ok.