serilog-archive / serilog-sinks-loggly

A Serilog event sink that writes to Loggly
Apache License 2.0
27 stars 30 forks source link

Migrate to xproj/project.json and add support for .NET Standard v1.5 #5

Closed jeremymeng closed 8 years ago

nblumhardt commented 8 years ago

LGTM! Thanks @jeremymeng.

@mivano shall we :shipit:?

(Just spotted http://stackoverflow.com/questions/39164167/serilog-loggly-csharp-fullnetfx/39197969#39197969)

jeremymeng commented 8 years ago

Thanks! However, configuration via app.config are not supported on the netstandard port though since the Api's are not available in .NET Core.

mivano commented 8 years ago

Sorry, I did not had time yet to go through this in detail and will be away for some weeks. So if all tested I would say yes, do ship it. But also do check if the right frameworks are targeted. I made some changes in the PR that @jeremymeng did for serilog metrics regarding the target frameworks.

jeremymeng commented 8 years ago

I made some changes in the PR that @jeremymeng did for serilog metrics regarding the target frameworks.

For Serilog Metrics I had net45 and netstandard1.1 for the library. I tried to get the supported netstandard version as low as possible to support more platforms. I used net451 for the test project because dotnet-test-nunit doesn't support net45.

jeremymeng commented 8 years ago

Anything I can do to move this PR forward? Thanks!

mivano commented 8 years ago

Sorry I'm in the middle of a house move so I have limited internet. @nblumhardt: can you check and merge?

Op do 15 sep. 2016 om 19:04 schreef Jeremy Meng notifications@github.com

Anything I can do to move this PR forward? Thanks!

— You are receiving this because you were mentioned.

Reply to this email directly, view it on GitHub https://github.com/serilog/serilog-sinks-loggly/pull/5#issuecomment-247388509, or mute the thread https://github.com/notifications/unsubscribe-auth/AAozd_lUvOKRIHNrshoJCymWmXh-Y6Y6ks5qqXqMgaJpZM4Jslg7 .

nblumhardt commented 8 years ago

:boom: :-)

jeremymeng commented 8 years ago

Thank you!